Updated LibSession to be sourced via Swift Package Manager #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Using a pre-built version of libSession as a SPM dependency for default builds
• Added a new scheme which will try to build libSession from source (update the `LIB_SESSION_SOURCE_DIR` User-Defined build setting to change the location - currently set to '${SRC_ROOT}/../LibSession-Util')
• Removed the libSession submodule
RyanRory
approved these changes
Sep 24, 2024
|
I want to hold off on merging this one until the code review feedback & changes for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the project to use a pre-built version of
libSessioninstalled via Swift Package Manager (seelibsession-util.xcframework.zipfrom https://github.com/oxen-io/libsession-util/releases/tag/v1.2.0-rc.1) by default instead of building from source and removes the submodule making the project easier to work with for those without experience dealing with CMake or complicated C/C++ dependenicesAdditionally it adds a new
Session_CompileLibSessionscheme which can be used to buildlibSessionfrom source (as we did prior to this PR) if desiredDebug_Compile_LibSessionandApp_Store_Release_Compile_LibSessionconfigurations which set aCOMPILE_LIB_SESSIONenvironment variable thatbuild_libSession_util.shuses to determine whether it should use the pre-built framework or build from sourceLIB_SESSION_SOURCE_DIRUser-Defined build setting which can be used to point at thelibSessionsource directory (currently set to${SRC_ROOT}/../LibSession-Util)Some quick stats on the differences between using the pre-built framework or building from source using an M1 Pro: